Backport handle errors gracefully to prevent SEGV to v4.1.x #13540
Conversation
oob_allgather_test() do not check isend() call success, leading to the possibility to use oob_req->reqs[] un-initialized upon error and thus to SEGV. Signed-off-by: Bruno Faccini <bfaccini@nvidia.com> (cherry picked from commit 109f4bc)
QiaoK
changed the title
ompi/mca/coll/ucc/coll_ucc_module.c
Outdated
| if (OMPI_SUCCESS != rc) { | ||
| return UCC_ERR_NO_MESSAGE; | ||
| } | ||
| rc = MCA_PML_CALL(irecv(tmprecv, msglen, MPI_BYTE, recvfrom, |
There was a problem hiding this comment.
The indenting appears to be incorrect.
|
Hello! The Git Commit Checker CI bot found a few problems with this PR: 1556b91: coll/ucc: Fix incorrect tab indentation.
Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks! |
QiaoK
force-pushed
the
ucc_seg_fix_v4.1.x
branch
from
1556b91 to
298d92a
Compare
|
Please don't use tabs -- we only use 4-space indenting here in Open MPI. https://docs.open-mpi.org/en/v5.0.x/developers/source-code.html Thanks! |
#13542 will fix this problem in the main branch. We can backport it here after merging that PR. |
Signed-off-by: Qiao Kang <qkang@nvidia.com> (cherry picked from commit 3980e80)
| if (OMPI_SUCCESS != rc) { | ||
| return UCC_ERR_NO_MESSAGE; | ||
| } |
There was a problem hiding this comment.
What about this one?
I see. We need to fix this in the main branch too. #13546.
4 participants
oob_allgather_test() do not check isend() call
success, leading to the possibility to use
oob_req->reqs[] un-initialized upon error and
thus to SEGV.
(cherry picked from commit 109f4bc)
Backport this fix in main branch to v4.1.x, so 4.1 version can run with UCC without segmentation fault.